fix(tls): detect modified CA and reissue certs #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
previously approved these changes
Jun 15, 2024
tthvo
approved these changes
Jun 15, 2024
tthvo
reviewed
Jun 15, 2024
|
/build_test |
|
|
andrewazores
approved these changes
Jun 17, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
* fix(tls): detect modified CA and reissue certs * Ignore certificate not found when deleting (cherry picked from commit fd1becc) # Conflicts: # bundle/manifests/cryostat-operator.clusterserviceversion.yaml
7 tasks
ebaron
added a commit
that referenced
this pull request
Jun 17, 2024
* fix(tls): detect modified CA and reissue certs (#897) * fix(tls): detect modified CA and reissue certs * Ignore certificate not found when deleting (cherry picked from commit fd1becc) # Conflicts: # bundle/manifests/cryostat-operator.clusterserviceversion.yaml * Fix conflicts --------- Co-authored-by: Elliott Baron <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Fixes: #896
Description of the change:
Motivation for the change:
How to manually test:
I tested on an OpenShift cluster, since the bug was very apparent when trying to access Cryostat using the route.
quay.io/ebaron/cryostat-operator-bundle:delete-cert-chain-01make deploy_bundle BUNDLE_IMG=quay.io/cryostat/cryostat-operator-bundle:2.4.0oc create -f config/samples/operator_v1beta1_cryostat.yaml./bin/operator-sdk run bundle-upgrade <bundle image for this PR>curl -k -sSI https://cryostat-sample-cryostat-operator-system.apps.example.com